Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump version to 9.0.0-dev #890

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented Jan 5, 2020

Motivation and Context

Prepare repo for next major development and release.

Description

Bump repo's version to 9.0.0-dev in:

  • package.json
  • VERSION
  • bin/templates/cordova/version
  • bin/templates/project/assets/www/cordova.js
  • framework/build.gradle
  • framework/src/org/apache/cordova/CordovaWebView.java

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 9.0.0 milestone Jan 5, 2020
@codecov-io
Copy link

codecov-io commented Jan 5, 2020

Codecov Report

Merging #890 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #890   +/-   ##
=======================================
  Coverage   66.25%   66.25%           
=======================================
  Files          19       19           
  Lines        1861     1861           
=======================================
  Hits         1233     1233           
  Misses        628      628

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e42fedc...9a06eb8. Read the comment docs.

Copy link
Contributor

@brodycj brodycj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

My one question is if we can think of a good (better) way to automate some of this work?

@erisu
Copy link
Member Author

erisu commented Jan 6, 2020

@brodybits I am sure we could use coho since it contains already a step that does the version bumping for the releases, but I was not investing the time to include it into my development process. For now, this manual process was much easier and faster.

Also, as a side note, I had been looking into the idea of removing all these version locations and condense it down between one or two file locations only.

@erisu erisu merged commit d0f972e into apache:master Jan 6, 2020
@erisu erisu deleted the v9-bump-version branch January 6, 2020 03:07
@erisu erisu mentioned this pull request Jan 6, 2020
1 task
@erisu erisu added this to Done in Release Plan - 9.1.0 Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants