Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename gradle plugin google services preference options #898

Merged
merged 1 commit into from
Jan 16, 2020
Merged

chore: rename gradle plugin google services preference options #898

merged 1 commit into from
Jan 16, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented Jan 16, 2020 •
edited
Loading

Motivation and Context

Change preference option names to increase better clarity by including more details.

Applied a pattern for all gradle related plugins:

GradlePlugin<Plugin-Name><Action/Property>

Description

  • GradlePluginGoogleServicesEnabled
  • GradlePluginGoogleServicesVersion

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 9.0.0 milestone Jan 16, 2020
@erisu erisu added this to In progress in Release Plan - 9.1.0 via automation Jan 16, 2020
@erisu erisu moved this from In progress to Review in progress in Release Plan - 9.1.0 Jan 16, 2020
jcesarmobile
jcesarmobile approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Release Plan - 9.1.0 automation moved this from Review in progress to Reviewer approved Jan 16, 2020
@erisu erisu mentioned this pull request Jan 16, 2020
Merged
2 tasks
@erisu erisu merged commit 09256b7 into apache:master Jan 16, 2020
Release Plan - 9.1.0 automation moved this from Reviewer approved to Done Jan 16, 2020
@erisu erisu deleted the feat/google-services branch January 16, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

@dpogue dpogue Awaiting requested review from dpogue

@timbru31 timbru31 Awaiting requested review from timbru31

Assignees
No one assigned
Labels
enhancement
Projects
No open projects
Release Plan - 9.1.0
  
Done
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erisu @jcesarmobile