Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (adb): shell to return expected stdout #904

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented Jan 21, 2020

Motivation and Context

Fix error when executing cordova run android to launch app in emulator.

Description

When executing cordova run android to launch the app in an emulator, the Adb.shell method does not return the expected stdout anymore and results in the following error

output.match is not a function

This bug was introduced during the execa refactor.

Testing

  • npm t
  • cordova run android

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added the bug label Jan 21, 2020
@erisu erisu added this to the 9.0.0 milestone Jan 21, 2020
@erisu erisu requested a review from breautek January 21, 2020 02:37
@erisu erisu added this to In progress in Release Plan - 9.1.0 via automation Jan 21, 2020
@codecov-io
Copy link

codecov-io commented Jan 21, 2020

Codecov Report

Merging #904 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
+ Coverage   66.17%   66.19%   +0.01%     
==========================================
  Files          19       19              
  Lines        1839     1840       +1     
==========================================
+ Hits         1217     1218       +1     
  Misses        622      622
Impacted Files Coverage Δ
bin/templates/cordova/lib/Adb.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64ef13c...1b676c8. Read the comment docs.

@erisu erisu requested a review from timbru31 January 21, 2020 09:28
@erisu erisu moved this from In progress to Review in progress in Release Plan - 9.1.0 Jan 21, 2020
Release Plan - 9.1.0 automation moved this from Review in progress to Reviewer approved Jan 21, 2020
Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the issue on master, and confirmed that this PR fixes the issue.

@erisu erisu merged commit 0924654 into apache:master Jan 21, 2020
Release Plan - 9.1.0 automation moved this from Reviewer approved to Done Jan 21, 2020
@erisu erisu deleted the fix/emulator-shell branch January 21, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants