fix: GH-935 replaced compare-func with native sort method #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In draft because there is an issue preventing tests from running successfully on NodeJS 12. |
Should I wait for #938 before I merge? Not sure what would be acceptable here, given the circumstances... |
|
You will need to rebase first. |
breautek
force-pushed
the
gh-935-remove-compare-func
branch
from
b60c4dd
to
6c8bfc5
Compare
Codecov Report
@@ Coverage Diff @@
## master #937 +/- ##
==========================================
+ Coverage 65.27% 65.42% +0.15%
==========================================
Files 21 21
Lines 1817 1828 +11
==========================================
+ Hits 1186 1196 +10
- Misses 631 632 +1
Continue to review full report at Codecov.
|
raphinesse
added a commit
to raphinesse/cordova-android
that referenced
this pull request
Oct 19, 2020
This reverts the fileSorter to the state from before apache#937, but using our own simple re-implementation of `compare-func`.
raphinesse
added a commit
to raphinesse/cordova-android
that referenced
this pull request
Nov 19, 2020
This reverts the fileSorter to the state from before apache#937, but using our own simple re-implementation of `compare-func`.
raphinesse
added a commit
to raphinesse/cordova-android
that referenced
this pull request
Nov 21, 2020
This reverts the fileSorter to the state from before apache#937, but using our own simple re-implementation of `compare-func`.
raphinesse
added a commit
that referenced
this pull request
Nov 21, 2020
* refactor(ProjectBuilder): less repetitive fileSorter This reverts the fileSorter to the state from before #937, but using our own simple re-implementation of `compare-func`. * fix(ProjectBuilder): apply sort RegExp to basename only * refactor(ProjectBuilder): use fast-glob instead of hand-rolled equivalent * refactor(ProjectBuilder): factor out common isPathArchSpecific * refactor(ProjectBuilder): use includes instead of indexOf * refactor(ProjectBuilder): move sorting into findOutputFilesHelper * refactor(ProjectBuilder): simplify findOutputFiles signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
compare-func& its sub-dependencydot-propare two unmaintained packages with reported vulnerabilities as documented in #935Closes #935
Description
I removed the
compare-funcfunction and replaced its one and only usage inProjectBuilderclass using the native arraysortmethod.Testing
The sort method was already tested, and the new sort implementation still passes the tests.
Checklist
(platform)if this change only applies to one platform (e.g.(android))