Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-8260: (browser) Fix corrupted zip file (build) #25

Closed
wants to merge 2 commits into from
Closed

CB-8260: (browser) Fix corrupted zip file (build) #25

wants to merge 2 commits into from

Conversation

VinceOPS
Copy link

@VinceOPS VinceOPS commented Dec 1, 2016

Platforms affected

Platform "browser" only.

What does this PR do?

Replace the node module adm-zip, which is known for corrupting some files when compressing a folder to a zip archive, by the module archiver.
Update the build script in order to use archiver instead of adm-zip.

What testing has been done on this change?

Making sure that all the different types of file bundled in the newly built package.zip were properly compressed, and uncompressed.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@purplecabbage
Copy link
Contributor

I like this, and thank you, however, I am planning on removing zip functionality.
I believe zipping was only added because someone decided that build needed some sort of output.
Realistically, I think it makes more sense to let users zip their own build output as they see fit, and remove these extra deps.

@asfgit asfgit closed this in d44ed62 May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants