Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-14145 resolve npm audit issues in patch release #53

Merged
merged 7 commits into from Jul 11, 2018

Conversation

brodybits
Copy link

@brodybits brodybits commented Jul 4, 2018

Platforms affected

Browser

What does this PR do?

  • resolve npm audit issues in patch release
  • pin other dependencies
  • update bundledDependencies to support deprecated Node.js 4
  • Include Node.js 10 in Appveyor CI & Travis CI
  • include the following update from cordova-js (using local coho with Improve patch release support cordova-coho#176 for patch release support):
    • CB-9366 log error.stack in cordova.js
  • Set VERSION to 5.0.4-dev & update JS snapshot to version 5.0.4-dev via coho, using local coho with Improve patch release support cordova-coho#176 for patch release support

What testing has been done on this change?

  • created new Cordova project using Node.js 8, add local cordova-browser update, and ran on both Safari and Chrome (Chromium) with no issues
  • created new Cordova project using Node.js 4 (deprecated) and 8, added proposed cordova-browser update from local file system (in a clean state), and ran on both Safari and Chromium with no issues
  • npm test on AppVeyor CI & Travis CI
  • npm audit with npm@6.1.0 (latest version) shows 0 vulnerabilities

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. (with some exceptions)
  • Added automated test coverage as appropriate for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant