Telemetry #247

omefire · 2016-05-02T20:43:10Z

Here is the related proposal: apache/cordova-discuss#43

omefire · 2016-05-08T21:39:15Z

This code relies on the insight package: https://www.npmjs.com/package/insight
However, due to a bug within insight, when the command prompt timeout expires, it won't automatically opt the user out, leading to the prompt being displayed again the next time cordova is run.

I have a patch to fix this issue here:
yeoman/insight#47

Use the patch to test this PR.

csantanapr · 2016-05-09T18:17:21Z

LGTM

stevengill · 2016-05-10T00:08:44Z

LGTM!!

nikhilkh · 2016-05-10T16:25:56Z

doc/cordova.txt

+    cordova-cli telemetry on
+    cordova-cli telemetry off
+    cordova-cli build --no-telemetry


These examples are not necessarily needed here as they are simple and not common scenarios - it will be nice to keep this output as small as it could be.

omefire · 2016-05-10T21:38:33Z

Related: apache/cordova-docs#599

nikhilkh · 2016-05-11T18:00:13Z

doc/cordova.txt

@@ -21,7 +23,7 @@ Project Commands
    run ................................ Run project
                                            (including prepare && compile)
    serve .............................. Run project with a local webserver
-                                            (including prepare)
+                                            (including prepare)                                          


Trailing spaces after (including prepare).

omefire · 2016-05-12T05:31:45Z

ping ...

csantanapr · 2016-05-12T10:12:19Z

I have one question, maybe I missed it in discussion why is this implemented in CLI and not LIB

I think it make more sense to implement in the top level of API entry points in LIB like create platform plugin etc.

In LIB will be disable by default
CLI will call API with new parameter to enable telemetry
CLI telemetry will
Be enable by default and CLI will offer user a CLI flag and env to disable telemetry

purplecabbage · 2016-05-12T16:17:37Z

Other CLIs that use lib (as a lib) would not want this code. Off by default is interesting, but I think this is cleaner, and it's done.

On May 12, 2016, at 3:12 AM, Carlos Santana notifications@github.com wrote:

I have one question, maybe I missed it in discussion why is this implemented in CLI and not LIB

I think it make more sense to implement in the top level of API entry points in LIB like create platform plugin etc.

In LIB will be disable by default
CLI will call API with new parameter to enable telemetry
CLI telemetry will
Be enable by default and CLI will offer user a CLI flag and env to disable telemetry

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub

nikhilkh · 2016-05-12T16:55:59Z

doc/cordova.txt

@@ -5,6 +5,7 @@ Synopsis
 Global Commands
    create ............................. Create a project
    help ............................... Get help for a command
+    telemetry .......................... Turn telemetry collection on or off


The CLI reference docs need an update.

Hmm, I thought it was generated from these files. Anyway, it's been updated.

They live in doc/readme.md.

Yes, I've already updated it and pushed to this PR. thanks.

omefire · 2016-05-12T17:22:35Z

I have one question, maybe I missed it in discussion why is this implemented in CLI and not LIB

I think it make more sense to implement in the top level of API entry points in LIB like create platform > plugin etc.

In LIB will be disable by default
CLI will call API with new parameter to enable telemetry
CLI telemetry will
Be enable by default and CLI will offer user a CLI flag and env to disable telemetry

I first wanted to go that route, but I then realized doing it in CLI minimizes polluting LIB for a functionality that's not intended to be used by downstream tools. It seems cleaner to handle it here, as mentioned by @purplecabbage

csantanapr · 2016-05-12T17:53:13Z

Sounds good to me to proceed then, it was a random idea

…, More documentation, etc...

nikhilkh · 2016-05-12T19:31:58Z

LGTM

purplecabbage · 2016-05-14T00:31:09Z

Was there ever a specific Jira issue for adding telemetry? I don't see it.
I think we need to revisit some of the output/prompt formatting, here is what I just saw:

dline2@1.0.1, run-async@0.1.0, lodash@3.10.1)
/usr/local/bin/cordova -> /usr/local/lib/node_modules/cordova/bin/cordova
? May Cordova anonymously report usage statistics to improve the tool over time? Yes
(Y/n) Yrdova anonymously report usage
Thanks for opting into telemetry to help us improve cordova.
6.2.1-dev (cordova-lib@6.2.1-dev)
jessem-osx:cordova-cli jessem$

Multiple overlapping lines, could be a bash issue as well.

nikhilkh · 2016-05-16T17:45:53Z

@omefire Can you please take a look into this?

omefire · 2016-05-16T17:52:05Z

@purplecabbage, I didn't create a JIRA issue to track the telemetry work, I should have. It was an oversight on my part. My bad.

I've tested this on MAC(El Capitan) and Windows10, but couldn't repro your issue.
What OS are you using ? I suspect this could be an issue with bash. I checked and couldn't find any such issue reported for inquirer, the underlying package that handles this.

purplecabbage · 2016-05-16T17:55:38Z

I am using windows 10, but I typically use the git-bash shell which may be
why we aren't seeing the same things.

@purplecabbage
risingj.com

On Mon, May 16, 2016 at 10:52 AM, Omar Mefire notifications@github.com
wrote:

@purplecabbage https://github.com/purplecabbage, I didn't create a JIRA
issue to track the telemetry work, I should have. My bad.
I've tested this on MAC(El Capitan) and Windows10, but couldn't repro your
issue.
What OS are you using ? I suspect this could be an issue with bash. I
checked and couldn't find any such issue reported for inquirer, the
underlying package that handles this.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#247 (comment)

omefire · 2016-05-16T19:27:18Z

@purplecabbage , I can't repro this with git-bash shell on Win10 because I'm running into another issue: nodejs/node#3006

The gist of my issue is that the process is not recognized to be running as TTY, which leads to insight ending the process and opting out:

Furthermore, commenting that code out, leads to yet another error: SBoudrias/Inquirer.js#290

Insight, which we depend on doesn't play well with git-bash/MinGW.

omefire · 2016-05-16T20:00:18Z

@purplecabbage , could you please file a JIRA issue for what you've encountered ?
I just did the same for the issues I just mentioned: https://issues.apache.org/jira/browse/CB-11276

omefire force-pushed the Telemetry branch 4 times, most recently from b3f0bab to 289619c Compare May 8, 2016 21:02

omefire force-pushed the Telemetry branch 2 times, most recently from 2652b45 to 6f0c505 Compare May 9, 2016 18:00

omefire force-pushed the Telemetry branch 3 times, most recently from f24b513 to 0e3c6de Compare May 9, 2016 18:51

omefire force-pushed the Telemetry branch 2 times, most recently from cfb2838 to 5f0f839 Compare May 10, 2016 03:05

nikhilkh reviewed May 10, 2016
View reviewed changes

omefire force-pushed the Telemetry branch from 44c26ea to 64a0c9e Compare May 11, 2016 16:27

nikhilkh reviewed May 11, 2016
View reviewed changes

omefire force-pushed the Telemetry branch 3 times, most recently from 4676c01 to f5133de Compare May 12, 2016 04:51

nikhilkh reviewed May 12, 2016
View reviewed changes

omefire force-pushed the Telemetry branch from f5133de to dcfb06a Compare May 12, 2016 17:50

omefire force-pushed the Telemetry branch 2 times, most recently from bb1901e to f4e1298 Compare May 12, 2016 18:12

omefire added 5 commits May 12, 2016 11:13

Telemetry: The Foundational work

eafb8b9

Telemetry: 'cordova telemetry on' && 'cordova telemetry off'

330dea1

Telemetry: Adding Unit Tests

55df898

Telemetry: CLI Documentation

50016c9

Telemetry: Refactor telemetry calls into a single spot, Change prompt…

39e5f17

…, More documentation, etc...

omefire force-pushed the Telemetry branch from f4e1298 to 39e5f17 Compare May 12, 2016 18:15

Telemetry: Update README.md documentation

304a9c3

omefire force-pushed the Telemetry branch from adeb7b6 to 304a9c3 Compare May 12, 2016 19:45

asfgit closed this in 94190b8 May 12, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Telemetry #247

Telemetry #247

omefire commented May 2, 2016 •

edited

Loading

omefire commented May 8, 2016 •

edited

Loading

csantanapr commented May 9, 2016

stevengill commented May 10, 2016

nikhilkh May 10, 2016

omefire commented May 10, 2016

nikhilkh May 11, 2016

omefire commented May 12, 2016

csantanapr commented May 12, 2016

purplecabbage commented May 12, 2016

nikhilkh May 12, 2016

omefire May 12, 2016

nikhilkh May 12, 2016

omefire May 12, 2016 •

edited

Loading

omefire commented May 12, 2016 •

edited

Loading

csantanapr commented May 12, 2016

nikhilkh commented May 12, 2016

purplecabbage commented May 14, 2016

nikhilkh commented May 16, 2016

omefire commented May 16, 2016 •

edited

Loading

purplecabbage commented May 16, 2016

omefire commented May 16, 2016

omefire commented May 16, 2016

Telemetry #247

Telemetry #247

Conversation

omefire commented May 2, 2016 • edited Loading

omefire commented May 8, 2016 • edited Loading

csantanapr commented May 9, 2016

stevengill commented May 10, 2016

nikhilkh May 10, 2016

Choose a reason for hiding this comment

omefire commented May 10, 2016

nikhilkh May 11, 2016

Choose a reason for hiding this comment

omefire commented May 12, 2016

csantanapr commented May 12, 2016

purplecabbage commented May 12, 2016

nikhilkh May 12, 2016

Choose a reason for hiding this comment

omefire May 12, 2016

Choose a reason for hiding this comment

nikhilkh May 12, 2016

Choose a reason for hiding this comment

omefire May 12, 2016 • edited Loading

Choose a reason for hiding this comment

omefire commented May 12, 2016 • edited Loading

csantanapr commented May 12, 2016

nikhilkh commented May 12, 2016

purplecabbage commented May 14, 2016

nikhilkh commented May 16, 2016

omefire commented May 16, 2016 • edited Loading

purplecabbage commented May 16, 2016

omefire commented May 16, 2016

omefire commented May 16, 2016

omefire commented May 2, 2016 •

edited

Loading

omefire commented May 8, 2016 •

edited

Loading

omefire May 12, 2016 •

edited

Loading

omefire commented May 12, 2016 •

edited

Loading

omefire commented May 16, 2016 •

edited

Loading