Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-11913 - Re-fix appveyor.yml to use specific node versions #263

Closed
wants to merge 1 commit into from
Closed

CB-11913 - Re-fix appveyor.yml to use specific node versions #263

wants to merge 1 commit into from

Conversation

shazron
Copy link
Member

@shazron shazron commented Oct 10, 2016

Platforms affected

All

What does this PR do?

Fix appveyor.yml node versions, they were incorrect previously

What testing has been done on this change?

The test will be on Appveyor (automated with this PR)

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@shazron
Copy link
Member Author

shazron commented Oct 11, 2016

Now that I've got appveyor node versions "working", it reflects the node 6 failures on Travis. Now to get node 6 working (npm link shenanigans).

@shazron
Copy link
Member Author

shazron commented Oct 12, 2016

Might be related: npm/npm#9633

@shazron
Copy link
Member Author

shazron commented Oct 12, 2016

Nah its npm/npm#10343

@stevengill
Copy link
Contributor

hows it going on this?

@shazron
Copy link
Member Author

shazron commented Oct 14, 2016

@stevengill unfortunately npm/npm#9633 strikes its head (see AppVeyor failure). Usually running npm install again fixes it, but once the first npm install fails it just fails the build

@shazron
Copy link
Member Author

shazron commented Oct 14, 2016

@stevengill since yarn works flawlessly on node 6 the alternative is, put all the install commands in a script and use yarn when we detect node 6. Kinda like my script here: npm/npm#10343 (comment)

For node 6, because of 'npm install' after 'npm link' bugs (see npm/npm#9633 and npm/npm#10343), we downgrade to use npm@2
@shazron
Copy link
Member Author

shazron commented Oct 14, 2016

Final fix that worked: downgrade to npm@2

@asfgit asfgit closed this in 576c842 Oct 15, 2016
@shazron shazron deleted the CB-11913 branch October 15, 2016 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants