Remove mentions of 'cordova plugin search' from docs#306
Merged
Conversation
dpogue
approved these changes
Aug 30, 2018
dpogue
left a comment
dpogue
left a comment
Member
There was a problem hiding this comment.
👍 but I'll hold off on merging until we actually remove it
Member
Author
|
@raphinesse Can you confirm that |
Member
|
(sorry for messing with this PR by deleting the translations) |
raphinesse
added a commit
that referenced
this pull request
Aug 30, 2018
raphinesse
force-pushed
the
deprecate-plugin-search
branch
from
August 30, 2018 12:24
cf2040f to
33d4f34
Compare
Contributor
|
Rebased onto current master |
raphinesse
approved these changes
Aug 30, 2018
raphinesse
left a comment
raphinesse
left a comment
Contributor
There was a problem hiding this comment.
Approved with the same remark as there:
apache/cordova-lib#671 (review)
1 task
janpio
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
none
What does this PR do?
Remove (deprecate)
cordova plugin searchrelated help docs.Related to PR: apache/cordova-lib#671
What testing has been done on this change?
npm test