New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mentions of 'cordova plugin search' from docs #306

Merged
merged 1 commit into from Aug 30, 2018

Conversation

4 participants
@erisu
Contributor

erisu commented Aug 30, 2018

Platforms affected

none

What does this PR do?

Remove (deprecate) cordova plugin search related help docs.

Related to PR: apache/cordova-lib#671

What testing has been done on this change?

  • npm test

@erisu erisu requested a review from raphinesse Aug 30, 2018

@dpogue

dpogue approved these changes Aug 30, 2018

👍 but I'll hold off on merging until we actually remove it

@erisu

This comment has been minimized.

Contributor

erisu commented Aug 30, 2018

@raphinesse Can you confirm that raw in cordova-lib has been deprecated?
In one of your commits, you removed raw and some of the test code in cordova-cli is looking for raw. It seems the tests are failing around this.

apache/cordova-lib@ed1ad43

@janpio

This comment has been minimized.

Contributor

janpio commented Aug 30, 2018

(sorry for messing with this PR by deleting the translations)

raphinesse added a commit that referenced this pull request Aug 30, 2018

@raphinesse

This comment has been minimized.

Contributor

raphinesse commented Aug 30, 2018

Rebased onto current master

@raphinesse

Approved with the same remark as there:
apache/cordova-lib#671 (review)

Apache Cordova: Next Release Planning and Tracking automation moved this from Pending Review to Pending Release Aug 30, 2018

@erisu erisu referenced this pull request Aug 30, 2018

Merged

Deprecate 'cordova plugin search' command #671

1 of 1 task complete

@raphinesse raphinesse merged commit 6b77379 into apache:master Aug 30, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Apache Cordova: Next Release Planning and Tracking automation moved this from Pending Release to Done Aug 30, 2018

@janpio janpio changed the title from Deprecate 'cordova plugin search' command docs to Remove mentions of 'cordova plugin search' from docs Aug 30, 2018

@brodybits brodybits referenced this pull request Sep 21, 2018

Merged

Start version 8.1.0 #333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment