Stub telemetry calls during ALL tests #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes _all_ `describe` blocks in cli.spec descendants of a common top-level `describe` block which stubs any critical telemetry methods. Thus we ensure that telemetry is never collected during test runs.
raphinesse
added this to 🐣 New PR / Untriaged
in Apache Cordova: Tooling Pull Requests
via automation
|
Approved, please merge
|
Apache Cordova: Tooling Pull Requests
automation
moved this from 🐣 New PR / Untriaged
to 🏆 Merged, waiting for Release
Sep 16, 2018
brodybits
pushed a commit
to brodybits/cordova-cli
that referenced
this pull request
Nov 26, 2018
This change makes _all_ `describe` blocks in cli.spec descendants of a common top-level `describe` block which stubs any critical telemetry methods. Thus we ensure that telemetry is never collected during test runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes all
describeblocks in cli.spec descendants of acommon top-level
describeblock which stubs any critical telemetrymethods.
Thus we ensure that telemetry is never collected during test runs.
All changes should be whitespace only.