Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CB-13740 safe requirements check #335

Merged
merged 1 commit into from
Sep 25, 2018
Merged

CB-13740 safe requirements check #335

merged 1 commit into from
Sep 25, 2018

Conversation

purplecabbage
Copy link
Contributor

gracefully handle platforms that don't pass back requirements to check

Platforms affected

  • any platform that does not correctly return an array of requirements to check

What does this PR do?

  • skips gracefully

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@project-bot project-bot bot added this to new/unassigned/reopened prs in Apache Cordova: project-bot automation testing Sep 25, 2018
@project-bot project-bot bot moved this from new/unassigned/reopened prs to accepted prs in Apache Cordova: project-bot automation testing Sep 25, 2018
@purplecabbage purplecabbage merged commit 890d336 into apache:master Sep 25, 2018
@project-bot project-bot bot moved this from accepted prs to merged prs in Apache Cordova: project-bot automation testing Sep 25, 2018
@purplecabbage purplecabbage deleted the CB-13740 branch September 25, 2018 22:34
@janpio janpio mentioned this pull request Sep 27, 2018
Closed
brodybits pushed a commit to brodybits/cordova-cli that referenced this pull request Nov 25, 2018
@purplecabbage
CB-13740 gracefully handle platforms that don't pass back requirement…
71d9468 
…s to check (apache#335)
This was referenced Nov 25, 2018
Closed
Closed
brodybits pushed a commit to brodybits/cordova-cli that referenced this pull request Nov 26, 2018
@purplecabbage
CB-13740 gracefully handle platforms that don't pass back requirement…
a016778 
…s to check (apache#335)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpio janpio janpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Apache Cordova: project-bot automatio...
merged prs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@purplecabbage @janpio