Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: update insight w/ updated code usage #573

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Dec 17, 2021

Motivation and Context

Update to use latest insight npm dependency

closes #566
closes #567

Description

Requires: #572

Updated Packages:

  • insight@^0.11.1

Other Notes:

In this version, the askPermission no longer accepts a callback method. It was converted to be a promise. Also, if the process is running with the CI flag, the default returned result will become undefined.

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 11.0.0 milestone Dec 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021

Codecov Report

Merging #573 (eb10744) into master (1ce2132) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
- Coverage   70.40%   70.31%   -0.10%     
==========================================
  Files           4        4              
  Lines         321      320       -1     
==========================================
- Hits          226      225       -1     
  Misses         95       95              
Impacted Files Coverage Δ
src/telemetry.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ce2132...eb10744. Read the comment docs.

@erisu erisu merged commit 3c5be8e into apache:master Dec 17, 2021
@erisu erisu deleted the dep/bump-insight branch December 17, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: macOS 12 monterey is not supported
3 participants