Remove test instructions for browserify #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
janpio
reviewed
Sep 11, 2018
| @@ -225,10 +225,6 @@ Ensure that mobilespec creates okay via CLI: | |||
| cordova-mobile-spec/createmobilespec/createmobilespec.js --android --ios | |||
| (cd mobilespec && ./cordova build && ./cordova run android) | |||
|
|
|||
| Ensure that mobilespec creates okay via CLI and browserify: | |||
|
|
|||
| (cd mobilespec && ./cordova prepare --browserify && ./cordova build && ./cordova run android) | |||
There was a problem hiding this comment.
should this maybe left in, just without --browserify?
There was a problem hiding this comment.
The block directly above it reads "Ensure that mobilespec creates okay via CLI:", so I'd say we've got that covered.
There was a problem hiding this comment.
I thought so too until I looked at the command which is pretty different (but I have no idea what exactly it does)
There was a problem hiding this comment.
This would be one of the rare cases where I'd trust the comments 😉
dpogue
approved these changes
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of apache/cordova#8