CB-9739 Prevent coho from creating broken packages including CRLF on … #95
Conversation
| @@ -76,6 +77,49 @@ exports.createCommand = function*(argv) { | |||
| var absOutDir = path.resolve(outDir); | |||
|
|
|||
| yield repoutil.forEachRepo(repos, function*(repo) { | |||
| if(isWin) { | |||
There was a problem hiding this comment.
Why the windows check?
Can a mac or linux users have a bad git config? and then the check will not run for them.
There was a problem hiding this comment.
We only have evidence of a problem with committers using Windows machine. In theory, this could happen on a Linux/mac machine - but the defaults ensure that this does not happen. Unless this is trivial - I would like us to move forward with getting this fix in for Windows.
There was a problem hiding this comment.
@nikhilkh I'm Ok with the change I was just curious of why the isWin, that's all.
I was not trying to blocked the merge. Merge away..
+1
There was a problem hiding this comment.
@csantanapr, git does not seem to change eols to CRLF on OS X given that core.autocrlf=false and/or core.eol=crlf. It probably could be changed by .gitattributes only (text eol=crlf).
There was a problem hiding this comment.
Thanks for the clarification @daserge
On Mac by default using git from XCode Tools, both of the settings core.autocrlf and core.eol are not set at all, so I would think let's leave this check only for Win as you have it here, go ahead and merge this PR
|
+1 to |
Windows
We may also need to add
.gitattributeswithto force LF line endings in the repos.
Jira issue