CB-13471 : added unit test for config file provider

[audreyso]

No description provided.

[stevengill]

Need to see why this is failing on appveyor

[raphinesse]

@stevengill @audreyso

The condition in this line has to be changed to work on Windows, since file will be res\xml (mind the backslash). Changing the condition to the following fixes it:

file.includes(path.join('res', 'xml'))

However, we still need to extend the test itself. It could be that someone uses the following on a Windows machine:

configFile.resolveConfigFilePath('project_dir', 'android', 'res/xml'))

Then we would fail again. Thus, we have to normalize the given path right at the start of configFile.resolveConfigFilePath:

file = path.normalize(file);

These two changes taken together will make the following test (and all others) pass on Windows:

it('resolveConfigFilePath should return file path', function () {
    [path.join('res', 'xml'), 'res/xml'].forEach(function (file) {
        var configPath = path.join('project_dir', 'app', 'src', 'main', file, 'xml');
        expect(configFile.resolveConfigFilePath('project_dir', 'android', file)).toBe(configPath);
    });
});

[dpogue]

Thanks @raphinesse! I've added a commit (attributed to you) with those changes, and fingers crossed for passing CI

[codecov-io]

Codecov Report

Merging #10 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   85.22%   85.23%   +<.01%     
==========================================
  Files          19       19              
  Lines        1767     1768       +1     
  Branches      376      376              
==========================================
+ Hits         1506     1507       +1     
  Misses        261      261

Impacted Files	Coverage Δ
src/ConfigChanges/ConfigFile.js	89.13% <100%> (+0.07%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8cca53...296a003. Read the comment docs.

[raphinesse]

Thanks for adding the commit and responding so quickly, @dpogue!