Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ConfigFile): group & cleanup tests #125

Merged
merged 5 commits into from Dec 20, 2019

Conversation

raphinesse
Copy link
Contributor

Minor test improvements. Review without whitespace changes.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes itself is OK.

I added some nitpick feedback for improving the test description. Will let you decide from here.

spec/ConfigChanges/ConfigFile.spec.js Outdated Show resolved Hide resolved
spec/ConfigChanges/ConfigFile.spec.js Outdated Show resolved Hide resolved
spec/ConfigChanges/ConfigFile.spec.js Outdated Show resolved Hide resolved
spec/ConfigChanges/ConfigFile.spec.js Outdated Show resolved Hide resolved
spec/ConfigChanges/ConfigFile.spec.js Outdated Show resolved Hide resolved
spec/ConfigChanges/ConfigFile.spec.js Outdated Show resolved Hide resolved
spec/ConfigChanges/ConfigFile.spec.js Outdated Show resolved Hide resolved
spec/ConfigChanges/ConfigFile.spec.js Outdated Show resolved Hide resolved
spec/ConfigChanges/ConfigFile.spec.js Outdated Show resolved Hide resolved
spec/ConfigChanges/ConfigFile.spec.js Outdated Show resolved Hide resolved
spec/ConfigChanges/ConfigFile.spec.js Outdated Show resolved Hide resolved
spec/ConfigChanges/ConfigFile.spec.js Outdated Show resolved Hide resolved
spec/ConfigChanges/ConfigFile.spec.js Outdated Show resolved Hide resolved
raphinesse and others added 2 commits December 20, 2019 12:45
Co-Authored-By: エリス <erisu@users.noreply.github.com>
@raphinesse raphinesse merged commit fd93323 into apache:master Dec 20, 2019
@raphinesse raphinesse deleted the config-change-group-tests branch December 20, 2019 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants