Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ConfigFile): minor improvements #134

Merged
merged 2 commits into from
Mar 15, 2020

Conversation

raphinesse
Copy link
Contributor

  • Improves casing of module variable name (configFile -> ConfigFile)
  • Get fresh module for each test to be able to make proper use of rewire

In preparation of merging #124.

@raphinesse raphinesse requested a review from erisu March 14, 2020 16:25
@codecov-io
Copy link

codecov-io commented Mar 14, 2020

Codecov Report

Merging #134 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   88.04%   88.04%           
=======================================
  Files          20       20           
  Lines        1171     1171           
=======================================
  Hits         1031     1031           
  Misses        140      140

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe6a73f...4324b02. Read the comment docs.

@erisu erisu merged commit fed6d05 into apache:master Mar 15, 2020
@raphinesse raphinesse deleted the config-file-spec-cleanup branch March 15, 2020 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants