Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in access & allow navigation #143

merged 1 commit into from Apr 19, 2020


Copy link

@erisu erisu commented Apr 18, 2020

Motivation, Context & Description

Cordova iOS Tests failing with latest common because of typos that was introduced in refactor #133.

  • allows_local_networkinallows_local_networking
  • requires_certificate_transparencrequires_certificate_transparency

This PR corrects the spelling.


  • npm t


  • I've run the tests to see all new and existing tests pass

@erisu erisu added the bug label Apr 18, 2020
@erisu erisu added this to the 4.0.1 milestone Apr 18, 2020
Copy link

codecov-io commented Apr 18, 2020

Codecov Report

Merging #143 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #143   +/-   ##
  Coverage   88.23%   88.23%           
  Files          20       20           
  Lines        1173     1173           
  Hits         1035     1035           
  Misses        138      138           
Impacted Files Coverage Δ
src/ConfigParser/ConfigParser.js 85.36% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be404bb...cd16b78. Read the comment docs.

@erisu erisu changed the title fix: typo in access tag rules fix: typo in access & allow navigation Apr 18, 2020
@erisu erisu merged commit 78affbb into apache:master Apr 19, 2020
@erisu erisu deleted the fix/typo-in-access-rules branch April 19, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants