Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove Node 10/12 from matrix. Added Node 16 and 18. #180

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

breautek
Copy link
Contributor

@breautek breautek commented Oct 14, 2022

Platforms affected

CI

Motivation and Context

Node 10/12 is now dated and EOL, therefore they have been removed from the matrix. Added Node 16 & 18 for modern test coverage.

Also appears to correct:

{'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

Which appears to occur on older Node engines.

Description

CI Matrix change

Testing

GH Actions will do it's thing.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2022

Codecov Report

Merging #180 (b023bad) into master (4d8475d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #180   +/-   ##
=======================================
  Coverage   87.79%   87.79%           
=======================================
  Files          20       20           
  Lines        1131     1131           
=======================================
  Hits          993      993           
  Misses        138      138           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@breautek breautek requested a review from erisu October 14, 2022 14:35
@breautek breautek merged commit fc966d1 into apache:master Oct 14, 2022
@breautek breautek deleted the ci/node branch October 14, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants