android: added monochrome attribute#197
Merged
erisu merged 1 commit intoapache:masterfrom Feb 1, 2023
Merged
Conversation
5 tasks
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
+ Coverage 88.38% 88.39% +0.01%
==========================================
Files 20 20
Lines 1145 1146 +1
==========================================
+ Hits 1012 1013 +1
Misses 133 133
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dpogue
approved these changes
Jan 25, 2023
Member
|
Why was this PR closed? |
Contributor
Author
|
@erisu Oh! I accidentally closed it thinking it was merged. Just opened it again. |
breautek
approved these changes
Feb 1, 2023
erisu
approved these changes
Feb 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
Motivation and Context
Android 13 added support for Themed Icons. Since themed icons aren't yet supported on Cordova Android, adding support for Themed icons inside
cordova-androidrequired modification to this project as the former project usesgetStaticResourcesfunction defined insidecordova-commonapache/cordova-android#1450
Description
Added support for parsing the monochrome icon for Android when preparing / updating the icons.
Testing
Checklist
(platform)if this change only applies to one platform (e.g.(android))