Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: added monochrome attribute #197

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Conversation

liyamahendra
Copy link
Contributor

@liyamahendra liyamahendra commented Jan 25, 2023

Platforms affected

  • android

Motivation and Context

Android 13 added support for Themed Icons. Since themed icons aren't yet supported on Cordova Android, adding support for Themed icons inside cordova-android required modification to this project as the former project uses getStaticResources function defined inside cordova-common

apache/cordova-android#1450

Description

Added support for parsing the monochrome icon for Android when preparing / updating the icons.

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2023

Codecov Report

Merging #197 (8f415cf) into master (cc78c81) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   88.38%   88.39%   +0.01%     
==========================================
  Files          20       20              
  Lines        1145     1146       +1     
==========================================
+ Hits         1012     1013       +1     
  Misses        133      133              
Impacted Files Coverage Δ
src/ConfigParser/ConfigParser.js 85.45% <100.00%> (+0.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erisu
Copy link
Member

erisu commented Jan 25, 2023

Why was this PR closed?

@liyamahendra
Copy link
Contributor Author

liyamahendra commented Jan 25, 2023

@erisu Oh! I accidentally closed it thinking it was merged. Just opened it again.

@liyamahendra liyamahendra reopened this Jan 25, 2023
@breautek breautek added this to the 5.0.0 milestone Feb 1, 2023
@erisu erisu merged commit ecad4db into apache:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants