Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cb 11968 - Add support for config-file in config.xml #2

Closed
wants to merge 1 commit into from

Conversation

matrosov-nikita
Copy link
Contributor

@matrosov-nikita matrosov-nikita commented Jul 7, 2017

cordova-windows changes: apache/cordova-windows#235

@filmaj
Copy link
Contributor

filmaj commented Jul 28, 2017

This LGTM but I will defer to @stevengill as he filed the original issue and is more familiar with it.

@filmaj
Copy link
Contributor

filmaj commented Jul 28, 2017

@matrosov-nikita can you actually rebase w/ latest master, I just added code coverage reporting to this repo. I just want to get a sense of if we're heading in the right direction.

@codecov-io
Copy link

Codecov Report

Merging #2 into master will increase coverage by 0.45%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   83.96%   84.42%   +0.45%     
==========================================
  Files          19       19              
  Lines        1734     1746      +12     
  Branches      365      369       +4     
==========================================
+ Hits         1456     1474      +18     
+ Misses        278      272       -6
Impacted Files Coverage Δ
src/ConfigParser/ConfigParser.js 75.51% <100%> (+0.59%) ⬆️
src/ConfigChanges/ConfigChanges.js 94.66% <100%> (+0.63%) ⬆️
src/util/xml-helpers.js 94.97% <0%> (+2.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4187f4...b20fd6d. Read the comment docs.

@matrosov-nikita
Copy link
Contributor Author

matrosov-nikita commented Aug 15, 2017

@filmaj, done.
@stevengill, could you please take a look?

@filmaj
Copy link
Contributor

filmaj commented Aug 22, 2017

Ping @stevengill - this blocks apache/cordova-windows#235

@stevengill
Copy link
Contributor

This LGTM. Thanks for implementing this one!

@asfgit asfgit closed this in af5c6dc Aug 23, 2017
@brodybits
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants