New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cb 11968 - Add support for config-file in config.xml #2
Conversation
94cebec
to
d275fd6
Compare
This LGTM but I will defer to @stevengill as he filed the original issue and is more familiar with it. |
@matrosov-nikita can you actually rebase w/ latest master, I just added code coverage reporting to this repo. I just want to get a sense of if we're heading in the right direction. |
d275fd6
to
b20fd6d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
==========================================
+ Coverage 83.96% 84.42% +0.45%
==========================================
Files 19 19
Lines 1734 1746 +12
Branches 365 369 +4
==========================================
+ Hits 1456 1474 +18
+ Misses 278 272 -6
Continue to review full report at Codecov.
|
@filmaj, done. |
Ping @stevengill - this blocks apache/cordova-windows#235 |
This LGTM. Thanks for implementing this one! |
Adding links: |
cordova-windows changes: apache/cordova-windows#235