Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-13685 android: Update ConfigParser for Adaptive Icons #26

Merged
merged 1 commit into from Aug 29, 2018

Conversation

@erisu
Copy link
Member

@erisu erisu commented Jun 8, 2018

Platforms affected

All

What does this PR do?

  • Add foreground and background attributes to be returned with the get static resources.

What testing has been done on this change?

  • Ran ESLint
  • Ran Jasmine tests
  • Ran cordova-android Jasmine Unit-Test. (requires this modification)
  • Build default app for Android platform.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.
@codecov-io
Copy link

@codecov-io codecov-io commented Jun 8, 2018

Codecov Report

Merging #26 into master will increase coverage by 0.73%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage    85.9%   86.63%   +0.73%     
==========================================
  Files          19       19              
  Lines        1738     1811      +73     
  Branches      361      387      +26     
==========================================
+ Hits         1493     1569      +76     
+ Misses        245      242       -3
Impacted Files Coverage Δ
src/ConfigParser/ConfigParser.js 76.89% <100%> (+0.16%) ⬆️
src/util/xml-helpers.js 95.67% <0%> (+0.72%) ⬆️
src/PluginInfo/PluginInfo.js 83.41% <0%> (+2.16%) ⬆️
src/CordovaError/CordovaError.js 65.51% <0%> (+20.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2dca1c...648356d. Read the comment docs.

@erisu erisu force-pushed the erisu:CB-13685 branch from 78cf3ce to 648356d Aug 10, 2018
@dpogue
dpogue approved these changes Aug 28, 2018
Copy link
Member

@dpogue dpogue left a comment

👍

@dpogue dpogue closed this Aug 28, 2018
@dpogue dpogue reopened this Aug 28, 2018
@dpogue dpogue merged commit 075e0ba into apache:master Aug 29, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@erisu erisu deleted the erisu:CB-13685 branch Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants