Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-12016: (all) Removed cordova-registry-mapper dependency #33

Merged
merged 1 commit into from Jul 13, 2018

Conversation

@erisu
Copy link
Member

@erisu erisu commented Jul 13, 2018

Platforms affected

all

What does this PR do?

Remove a forgotten dead dependency.

Ticket CB-12016 was to remove this dependency and had been resolved but appears cordova-common was forgotten.

What testing has been done on this change?

Tested adding plugins with old and new package name.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.
@brodybits
Copy link
Contributor

@brodybits brodybits commented Jul 13, 2018

❤️ hope it doesn't break anything, no time to check this week unfortunately.

Any comments from @raphinesse or @dpogue?

@erisu erisu force-pushed the erisu:CB-12016 branch from 2bab062 to 59e5e9a Jul 13, 2018
@codecov-io
Copy link

@codecov-io codecov-io commented Jul 13, 2018

Codecov Report

Merging #33 into master will increase coverage by 0.27%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #33      +/-   ##
=========================================
+ Coverage   85.62%   85.9%   +0.27%     
=========================================
  Files          19      19              
  Lines        1746    1738       -8     
  Branches      367     361       -6     
=========================================
- Hits         1495    1493       -2     
+ Misses        251     245       -6
Impacted Files Coverage Δ
src/PlatformJson.js 82.35% <0%> (+4.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bf9627...59e5e9a. Read the comment docs.

@dpogue
dpogue approved these changes Jul 13, 2018
Copy link
Member

@dpogue dpogue left a comment

👍

@dpogue dpogue merged commit d2dca1c into apache:master Jul 13, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@erisu erisu deleted the erisu:CB-12016 branch Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants