Do not ignore AppVeyor failures on Node.js 12 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-bot
bot
added this to 🐣 New PR / Untriaged
in Apache Cordova: Tooling Pull Requests
Apache Cordova: Tooling Pull Requests
automation
moved this from 🐣 New PR / Untriaged
to ✅ Approved, waiting for Merge
Jun 14, 2019
|
Just waiting for AppVeyor tests to complete, but expecting it will pass. |
Apache Cordova: Tooling Pull Requests
automation
moved this from ✅ Approved, waiting for Merge
to 🏆 Merged, waiting for Release
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
All
Motivation and Context
See appveyor/ci#2921: now that AppVeyor has Node.js 12 built-in, we should not ignore failures on that Node.js version.
Description
Remove the lines introduced in PR #68 to ignore AppVeyor failures on Node.js 12
Testing
Checklist
I added automated test coverage as appropriate for this changeCommit is prefixed with(platform)if this change only applies to one platform (e.g.(android))If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)I've updated the documentation if necessary