Fix ESLint violations where applicable #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-bot
bot
added this to 🐣 New PR / Untriaged
in Apache Cordova: Tooling Pull Requests
erisu
reviewed
Jul 18, 2019
Apache Cordova: Tooling Pull Requests
automation
moved this from 🐣 New PR / Untriaged
to ✅ Approved, waiting for Merge
Jul 18, 2019
erisu
reviewed
Jul 18, 2019
Apache Cordova: Tooling Pull Requests
automation
moved this from ✅ Approved, waiting for Merge
to 🏆 Merged, waiting for Release
Jul 18, 2019
This was referenced Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes most ESLint violations that were masked by ESLint comments. Two instances still remain. One is an acceptable usage of
evaland the other is inCordovaErrorthat should be fixed by its own commit.I noticed I had this lying around in my local fork when I reviewed #82.