Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop node 6 and 8 support #90

Merged
merged 1 commit into from Nov 6, 2019
Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented Sep 26, 2019

Motivation and Context

Description

  • Removes Node 6 and 8 from CI Testing Services
  • Bump engines.node to >=10 in package.json

Testing

  • npm t
  • CI services continue to pass

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 4.0.0 milestone Sep 26, 2019
@project-bot project-bot bot added this to 🐣 New PR / Untriaged in Apache Cordova: Tooling Pull Requests Sep 26, 2019
Apache Cordova: Tooling Pull Requests automation moved this from 🐣 New PR / Untriaged to ✅ Approved, waiting for Merge Sep 26, 2019
Copy link
Member

@timbru31 timbru31 left a comment

LGTM, but this please do not merge yet, as this is a BREAKING CHANGE

@erisu erisu merged commit 7ceeeb4 into apache:master Nov 6, 2019
2 checks passed
Apache Cordova: Tooling Pull Requests automation moved this from ✅ Approved, waiting for Merge to 🏆 Merged, waiting for Release Nov 6, 2019
@erisu erisu deleted the drop-node-6-8 branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Apache Cordova: Tooling Pull Requests
🏆 Merged, waiting for Release
Development

Successfully merging this pull request may close these issues.

None yet

2 participants