Skip to content

chore: drop node 6 and 8 support#90

Merged
erisu merged 1 commit into
apache:masterfrom
erisu:drop-node-6-8
Nov 6, 2019
Merged

chore: drop node 6 and 8 support#90
erisu merged 1 commit into
apache:masterfrom
erisu:drop-node-6-8

Conversation

@erisu
Copy link
Copy Markdown
Member

@erisu erisu commented Sep 26, 2019

Motivation and Context

Description

  • Removes Node 6 and 8 from CI Testing Services
  • Bump engines.node to >=10 in package.json

Testing

  • npm t
  • CI services continue to pass

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 4.0.0 milestone Sep 26, 2019
Copy link
Copy Markdown
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this please do not merge yet, as this is a BREAKING CHANGE

@erisu erisu merged commit 7ceeeb4 into apache:master Nov 6, 2019
@erisu erisu deleted the drop-node-6-8 branch November 6, 2019 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants