Cleanup tests #16
Merged
Cleanup tests #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diff best viewed with --anchored=checkConfigXml Co-authored-by: Christopher J. Brody <brodybits@litehelpers.net> Co-authored-by: Raphael von der Grün <raphinesse@gmail.com>
Co-authored-by: Christopher J. Brody <brodybits@litehelpers.net> Co-authored-by: Raphael von der Grün <raphinesse@gmail.com>
|
Seems to be missing check for presence vs absence of
Otherwise looks like very nice work. |
I would be fine to leave this part for another PR, if we can do this today. Agreed to squash these in the merge. |
|
@stevengill @dpogue @shazron If no one objects, I'm going to squash-merge this as soon as I find time for another self-review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top and further improves upon the great test cleanup done by @brodybits in #14. Due to #8 being blocked for now, I removed all related changes in the hopes that we can merge the remaining changes ASAP.
If you want to compare this with the original changes by @brodybits, compare against the second commit
5f0d79e. Everything after that is new.
I left the commits separate so the whole thing is easier to review. We can squash all of this on merge.