Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop node 6 and 8 support #47

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented Nov 1, 2019

Motivation and Context

Next major release, cordova-create@3.x will no longer test or require code to be backwards compatible with node 6 and 8.

Description

  • Removes node 6 and 8 from testing and package.json.
  • Updated minimum supported node version.

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 3.0.0 milestone Nov 1, 2019
@erisu erisu requested a review from raphinesse November 1, 2019 07:47
@project-bot project-bot bot added this to 🐣 New PR / Untriaged in Apache Cordova: Tooling Pull Requests Nov 1, 2019
Apache Cordova: Tooling Pull Requests automation moved this from 🐣 New PR / Untriaged to ✅ Approved, waiting for Merge Nov 1, 2019
Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu merged commit 16606c1 into apache:master Nov 5, 2019
Apache Cordova: Tooling Pull Requests automation moved this from ✅ Approved, waiting for Merge to 🏆 Merged, waiting for Release Nov 5, 2019
@erisu erisu deleted the v3-drop-old-node-support branch November 5, 2019 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Apache Cordova: Tooling Pull Requests
🏆 Merged, waiting for Release
Development

Successfully merging this pull request may close these issues.

None yet

3 participants