Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isRemoteUri #52

Merged
merged 3 commits into from Nov 6, 2019
Merged

Fix isRemoteUri #52

merged 3 commits into from Nov 6, 2019

Conversation

raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Nov 6, 2019

Motivation and Context

Fixes #34

Description

We use npm-package-arg to determine to what a spec refers. That's the package used by npm for spec parsing.

Testing

Added unit tests before the change, including one failing for #34. Tests all pass after change.

raphinesse added 3 commits Nov 6, 2019
Including one failing test for paths that include @
The reason for the rename is, that there are also local specs where we
need to call fetch. For example tarballs.
@raphinesse raphinesse added the bug label Nov 6, 2019
@raphinesse raphinesse added this to the 3.0.0 milestone Nov 6, 2019
@raphinesse raphinesse requested review from timbru31, erisu and breautek Nov 6, 2019
@project-bot project-bot bot added this to 🐣 New PR / Untriaged in Apache Cordova: Tooling Pull Requests Nov 6, 2019
Apache Cordova: Tooling Pull Requests automation moved this from 🐣 New PR / Untriaged to ✅ Approved, waiting for Merge Nov 6, 2019
Copy link

@breautek breautek left a comment

I didn't test it myself but lets good 👍

erisu
erisu approved these changes Nov 6, 2019
package.json Show resolved Hide resolved
@raphinesse raphinesse merged commit d894243 into apache:master Nov 6, 2019
2 checks passed
Apache Cordova: Tooling Pull Requests automation moved this from ✅ Approved, waiting for Merge to 🏆 Merged, waiting for Release Nov 6, 2019
@raphinesse raphinesse deleted the fix-is-remote branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Apache Cordova: Tooling Pull Requests
🏆 Merged, waiting for Release
Development

Successfully merging this pull request may close these issues.

4 participants