Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: various cleanup changes #63

Merged
merged 5 commits into from
Apr 16, 2020
Merged

chore: various cleanup changes #63

merged 5 commits into from
Apr 16, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented Apr 16, 2020

Motivation, Context & Description

Various cleanup changes:

  • Updated README.md format
  • Added npm install badge to README.md
  • Added missing NOTICE file
  • Added missing header license
  • Removed .ratignore
  • Added missing blank newline

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 3.0.0 milestone Apr 16, 2020
@codecov-io
Copy link

codecov-io commented Apr 16, 2020 •
edited
Loading

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   89.70%   89.70%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           61       61           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 975538a...8e66f39. Read the comment docs.

NiklasMerz
NiklasMerz approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@erisu erisu merged commit a399529 into apache:master Apr 16, 2020
@erisu erisu deleted the chore/various-cleanup branch April 16, 2020 11:07
raphinesse
raphinesse reviewed Apr 17, 2020
View reviewed changes
Copy link
Contributor

@raphinesse raphinesse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that this is already merged. Have my comments anyway 😅

LICENSE Show resolved Hide resolved
LICENSE Show resolved Hide resolved
spec/templates/no_content_config.xml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphinesse raphinesse raphinesse left review comments

@NiklasMerz NiklasMerz NiklasMerz approved these changes

@timbru31 timbru31 Awaiting requested review from timbru31

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erisu @codecov-io @raphinesse @NiklasMerz