Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: small syntax changes #64

Merged
merged 3 commits into from
Apr 17, 2020
Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented Apr 16, 2020

Motivation, Context & Description

  • Modernizing Syntax
    • var to let & const
    • arrow functions

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 3.0.0 milestone Apr 16, 2020
@codecov-io
Copy link

codecov-io commented Apr 16, 2020

Codecov Report

Merging #64 into master will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   89.70%   89.55%   -0.16%     
==========================================
  Files           1        1              
  Lines          68       67       -1     
==========================================
- Hits           61       60       -1     
  Misses          7        7              
Impacted Files Coverage Δ
index.js 89.55% <100.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a399529...3bc4b2b. Read the comment docs.

@erisu erisu merged commit 5f24bdb into apache:master Apr 17, 2020
@erisu erisu deleted the refactor/syntax-changes branch April 17, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants