Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of patch-package? #83

Open
brodybits opened this issue Dec 28, 2017 · 1 comment
Open

Use of patch-package? #83

brodybits opened this issue Dec 28, 2017 · 1 comment

Comments

@brodybits
Copy link

I discovered https://www.npmjs.com/patch-package which looks like a really nice way to deal with minor patches needed. I have no idea if there is any way people can use this to patch minor issues with upstream plugins, hope to look at this someday. Any ideas or suggestions from the user community?

@dpogue
Copy link
Member

dpogue commented Dec 28, 2017

This seems like a slightly nicer way of doing what I've done a few times. In my case I'd fix a Cordova bug, open a PR, and when save the patch in the root of my project, and apply it to the node_modules folder as a CI build step. It works well, but the problem is that it's not obvious to other developers that they need to apply patches manually.

For Cordova plugins however, the easiest option is always to try pointing at the git repo directly. You should only need to fallback to the patching hacks if there's a dependency chain that you can't satisfy with a git reference (i.e., cordova-plugin-file-transfer depends on a specific version of cordova-plugin-file, and you need to patch cordova-plugin-file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants