-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cordova-create] Simplify interface of main export (§1) #99
Comments
I do not see if the public cordovaCreate function API, which seems to be exported by both cordova-create and cordova-lib, was documented anywhere other than in a README. From NPM I see very few direct dependents of cordova-create, more dependents of cordova-lib including some gulp plugins (which seem to be a bit old). I think it would be good to get the Cordova tooling API documented. Should this be raised as a separate task? If we change the public cordovaCreate function API on cordova-create I would favor allowing the caller to inject the fetch function for smoother mocking. (No need for cordova-lib to export this option, I think.) |
Thanks for your feedback @brodybits !
Yes, the tooling libs definitely need better documentation. Prefereable in their respective README.
I'm not too fond of polluting the public interface for testing only. Jasmine spies and If we need DI for real-world use cases, I'm open to it. I would probably move it to a separate issue though, as it is an additional feature. |
This issue was moved to apache/cordova-create#21 |
Current situation
Arguments
Properties of
cfg
used incordovaCreate
¹¹: neither the
cfg
object nor parts larger than single leaf properties arepassed outside the scope of this module, so a local view on this is all we need.
Pain Points
Proposal
Arguments
Structure of
opts
Migrated from #89
The text was updated successfully, but these errors were encountered: