Changed armv7l architecture name #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The armv7l architecture has a L at the end instead of a 1. see https://github.com/electron/electron/releases
erisu
approved these changes
Mar 26, 2020
purplecabbage
pushed a commit
that referenced
this pull request
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The armv7l architecture has a L at the end instead of a 1. see https://github.com/electron/electron/releases
Platforms affected
none
Motivation and Context
It is the wrong name for this architecture. Developers, that are new to electron will have a hard time, figuring this out, if it is wrong.
Description
Changed "1" to small "L"
Testing
Checklist
(platform)if this change only applies to one platform (e.g.(android))