CB-9393: Documenting how to embed a SystemWebView #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@riknoll Bump, I've updated the branch |
| parser.parse(this); | ||
|
|
||
| SystemWebView webView = (SystemWebView) findViewById(R.id.tutorialView); | ||
| webInterface = new CordovaWebViewImpl(new SystemWebViewEngine(webView)); |
There was a problem hiding this comment.
webInterfaceneeds to be declared
|
Minor comments, but otherwise looks pretty good! |
|
Blargh! I need to hunt down the merge conflict before re-sending this pull request. I have no idea what changed on this file, though. |
| following: | ||
| private CordovaInterfaceImpl iface = new CordovaInterfaceImpl(this); | ||
|
|
||
| 1. Add the following to intialize the WebView |
There was a problem hiding this comment.
what if i want to override
setWebChromeClient(WebChromeClient client)
method of systemWebView
I got rutime error of class cast exception
There was a problem hiding this comment.
Commenting on old docs PRs is never the right solution. Better create a Stack Overflow question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of the pull request to update the SystemWebView documentation.