Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win8 removed + bb10 & ubuntu depreciation info #708

Closed
wants to merge 3 commits into from

Conversation

awebdeveloper
Copy link

Platforms affected

What does this PR do?

Removed info on win8 + bb10 & ubuntu depreciation info

What testing has been done on this change?

This is just a change to docs

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@@ -38,10 +38,9 @@ CLI's shorthand names.
<tr>
<th></td>
<th>android</th>
<th>blackberry10</th>
<th>blackberry10 (depricated)</th>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling -> correct: "deprecated"

<th>ios</th>
<th>Ubuntu</th>
<th>wp8<br/>(Windows Phone 8)</th>
<th>Ubuntu (depricated)</th>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling -> correct: "deprecated"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@shazron
Copy link
Member

shazron commented Jun 13, 2017

Thanks! Can you copy the file to the dev tree as well. This file: www/docs/en/dev/guide/support/index.md

@awebdeveloper
Copy link
Author

done

@shazron
Copy link
Member

shazron commented Jun 16, 2017

@purplecabbage is the removal of win8 here ok?

@purplecabbage
Copy link
Contributor

Nope, it seems there are some mixed up deletions ) from a quick glance.
This is the data that shows up on https://cordova.apache.org/docs/en/latest/guide/support/index.html right?
Windows column should be renamed to windows (uwp) and should still exist.

@awebdeveloper
Copy link
Author

awebdeveloper commented Jun 16, 2017

@purplecabbage you want me to rename windows column name to windows (uwp) from the existing windows (8.1, 10, Phone 8.1)

also anything else

@awebdeveloper
Copy link
Author

@purplecabbage ^^

@stevengill
Copy link
Contributor

@awebdeveloper I think that is correct. Rename windows (8.1, 10, Phone 8.1) to windows (uwp).

Also, it looks like you are removing

<td data-col="win8"       class="n"></td>

but I think you want to be removing

<td data-col="winphone8"  class="n"></td>

Also, can you do a rebase on master so this is mergable again?

Thanks!

@purplecabbage
Copy link
Contributor

purplecabbage commented Sep 26, 2017 via email

@janpio
Copy link
Member

janpio commented Oct 3, 2017

I changed a lot about this in #741. I think it would be better to wait for this to get merged and then remove what should be removed (Is there a JIRA issue about that?).

@awebdeveloper
Copy link
Author

Y not just remove the two columns in that PR itself

@janpio
Copy link
Member

janpio commented Oct 3, 2017

Because this PR does different things. Also I have no idea why this should happen as I couldn't find an issue that tells the reasoning behind the change with some confirmation from some Cordova person that this is indeed wanted.

@awebdeveloper
Copy link
Author

Also, following plugins are getting sunsetted

  1. file transfer- https://cordova.apache.org/blog/2017/10/18/from-filetransfer-to-xhr2.html

Even these are getting sunsetted but i didn't see them in the table on the site
1.device motion - https://blog.phonegap.com/migrating-from-the-cordova-device-motion-plugin-ddd8176632ed
2. device orientation - https://blog.phonegap.com/migrating-from-the-cordova-device-orientation-plugin-8442b869e6cc

@janpio
Copy link
Member

janpio commented Feb 23, 2018

Closing this as the remaining changes are for the wrong column (win8 is actuall the name of the windows platform).

@janpio janpio closed this Feb 23, 2018
@awebdeveloper awebdeveloper deleted the patch-1 branch February 28, 2018 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants