New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Win8 removed + bb10 & ubuntu depreciation info #708
Conversation
@@ -38,10 +38,9 @@ CLI's shorthand names. | |||
<tr> | |||
<th></td> | |||
<th>android</th> | |||
<th>blackberry10</th> | |||
<th>blackberry10 (depricated)</th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spelling -> correct: "deprecated"
<th>ios</th> | ||
<th>Ubuntu</th> | ||
<th>wp8<br/>(Windows Phone 8)</th> | ||
<th>Ubuntu (depricated)</th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spelling -> correct: "deprecated"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Thanks! Can you copy the file to the |
done |
@purplecabbage is the removal of win8 here ok? |
Nope, it seems there are some mixed up deletions ) from a quick glance. |
@purplecabbage you want me to rename windows column name to windows (uwp) from the existing windows (8.1, 10, Phone 8.1) also anything else |
@awebdeveloper I think that is correct. Rename Also, it looks like you are removing
but I think you want to be removing
Also, can you do a rebase on master so this is mergable again? Thanks! |
The pr is deleting the wrong column -> winphone8 is the one that is going.
Change the title in the windows column to read windows (uwp)
@purplecabbage
risingj.com
…On Tue, Sep 26, 2017 at 11:00 AM, Steve Gill ***@***.***> wrote:
@awebdeveloper <https://github.com/awebdeveloper> I think that is
correct. Rename windows (8.1, 10, Phone 8.1) to windows (uwp).
Also, it looks like you are removing
<td data-col="win8" class="n"></td>
but I think you want to be removing
<td data-col="winphone8" class="n"></td>
Also, can you do a rebase on master so this is mergable again?
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#708 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC0NpgKu99hB9kEQ8W6lOMbVLk3elRbks5smTupgaJpZM4N2Gso>
.
|
I changed a lot about this in #741. I think it would be better to wait for this to get merged and then remove what should be removed (Is there a JIRA issue about that?). |
Y not just remove the two columns in that PR itself |
Because this PR does different things. Also I have no idea why this should happen as I couldn't find an issue that tells the reasoning behind the change with some confirmation from some Cordova person that this is indeed wanted. |
Also, following plugins are getting sunsetted Even these are getting sunsetted but i didn't see them in the table on the site |
Closing this as the remaining changes are for the wrong column (win8 is actuall the name of the |
Platforms affected
What does this PR do?
Removed info on win8 + bb10 & ubuntu depreciation info
What testing has been done on this change?
This is just a change to docs
Checklist