fix(windows): electron window not displaying

[zoltan-mihalyi]

Platforms affected

• Windows (electron window is hidden)
• others (stdio is ignored)

Motivation and Context

On windows platform using nodejs 11+, the electron window does not appear.

Description

windowsHide: false makes the electron window appear on windows.

Testing

I manually tested my changes on windows.

Checklist

• I've run the tests to see all new and existing tests pass
• I added automated test coverage as appropriate for this change
• Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
• I've updated the documentation if necessary

[erisu]

Hey @zoltan-mihalyi,

Thank you for the PR.

I have configured my Windows environment and tested the before and after case to confirm the original issue and fix.

I would like to actually split this PR into two PRs. I know this PR is small and only changes one line, but IMO this PR is doing two things, a fix and a feature.

You can make the second PR based from the first. You or I can rebasae after we merge in the first fix PR.

First PR (Fix)

Lets convert this PR into a fix only PR.

• Change the PR title into something like this:

  fix(windows): electron window not displaying

• Update the description to only apply for this fix.
• Update the code to only apply the fix.

Second PR (Feature)

IMO, adding the stdio flag is more of a feature request and not apart of the fix.

Lets make a new PR for this feature request.

• Create a PR title into something like this:

  feat: display electron’s process stdio in terminal

• Set the description explaining the new feature, etc.
• Add new feature code.

Overall

The changes are good and works..

[zoltan-mihalyi]

@erisu The first PR is done, I will create the second one after this is finished.

[erisu]

@zoltan-mihalyi I just squashed merged the PR so you can update your fork copy and use the main branch to create the second PR from.

I will review & merge the second PR as soon as I see it ready & finishes running the tests.

[miroslavvojtus]

We have the same problem.
When we can expect the next version?