Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module.exports.prepare Test with Fix #23

Merged
merged 1 commit into from Feb 20, 2019

Conversation

GedasGa
Copy link
Contributor

@GedasGa GedasGa commented Feb 20, 2019

Platforms affected

none

Motivation and Context

Increase test coverage

Description

Wrote tests for module.exports.prepare. Fixed an issue in prepareIcons, discovered by testing. Also, removed my repo data from mock config.xml.

Testing

npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

- remove user specific repo declaration
- correct size validation in prepareIcons
@erisu erisu changed the title Test module.exports.prepare Add module.exports.prepare Test with Fix Feb 20, 2019
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #23 into master will increase coverage by 5.81%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   75.16%   80.98%   +5.81%     
==========================================
  Files          12       12              
  Lines         447      447              
==========================================
+ Hits          336      362      +26     
+ Misses        111       85      -26
Impacted Files Coverage Δ
bin/templates/cordova/lib/prepare.js 100% <100%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd76586...8e62d14. Read the comment docs.

@erisu erisu merged commit b9dfc10 into apache:master Feb 20, 2019
@GedasGa GedasGa deleted the test-prepare-final branch February 26, 2019 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants