Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump electron@^18.2.4 #234

Merged
merged 1 commit into from
May 30, 2022
Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented May 23, 2022

Motivation and Context

Use the latest electron package

Description

bump npm package electron version to ^18.2.4

Testing

npm t
cordova build

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu added enhancement dependencies Pull requests that update a dependency file labels May 23, 2022
@erisu erisu added this to the 4.0.0 milestone May 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2022

Codecov Report

Merging #234 (ff9918d) into master (48b1a82) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #234   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          656       656           
=========================================
  Hits           656       656           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48b1a82...ff9918d. Read the comment docs.

@erisu erisu merged commit a547e87 into apache:master May 30, 2022
@erisu erisu deleted the feat/bump-electron-18.x branch May 30, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants