Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: bump electron@^29.0.0 w/ supporting changes #263

Merged
merged 5 commits into from Feb 20, 2024

Conversation

erisu
Copy link
Member

@erisu erisu commented Jan 17, 2024

Platforms affected

electron

Motivation and Context

update to use latest released electron

Description

  • Bump electron dependency to ^29.0.0
  • Replace deprecated usage protocol.registerFileProtocol with protocol.handle
  • Remove deprecated usage protocol.interceptFileProtocol
  • Disabled sandbox setting. (When sandbox is enabled, appears that preload scripts and other require statements fails).
    • Future Task: Review and determin if we can support sandbox as optional, or completely migrate to sandbox. Needs to support Cordova plugin ecosystem. (third-party npm package support)
  • Simple plugin test with cordova-plugin-device
    • Confirmed that the native bridge communication still functions and results are fetched by third-party npm package and returned to front with method window.device.getInfo(e => console.log(e));

Testing

  • npm t
  • cordova run electron --nobuild
  • Confirmed that when scheme is set, file becomes inaccessible. (Should mimic previous behavior of interceptFileProtocol)
  • cordova build electron on macOS
    • Unconfigured. Standard dmg (with APFS) & zip package

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu changed the title feat!: bump electron@^28.1.4 w/ supporting changes feat!: bump electron@^29.0.0 w/ supporting changes Feb 20, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7053f35) 100.00% compared to head (af93e1f) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #263   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          656       656           
=========================================
  Hits           656       656           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erisu erisu merged commit 8fcde3a into apache:master Feb 20, 2024
9 checks passed
@erisu erisu deleted the feat/bump-electron branch February 20, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants