Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm(dep)!: bump electron-builder@^24.12.0 #264

Merged
merged 3 commits into from Feb 20, 2024

Conversation

erisu
Copy link
Member

@erisu erisu commented Feb 20, 2024

Platforms affected

electron

Motivation and Context

update to use latest released electron-builder

Description

  • bumped electron-builder@^24.12.0
  • bump node engine requirement to >= 18.0.0
  • drop unsupported node engines from CI

Testing

  • npm t
  • cordova build electron

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8fcde3a) 100.00% compared to head (fcf9915) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #264   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          656       656           
=========================================
  Hits           656       656           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erisu erisu force-pushed the feat/bump-electron-related-dependencies branch 2 times, most recently from 716384e to cba3365 Compare February 20, 2024 11:47
@erisu erisu changed the title Feat/bump electron related dependencies npm(dep)!: bump electron-builder@^24.12.0 Feb 20, 2024
@erisu erisu force-pushed the feat/bump-electron-related-dependencies branch from 4ada68f to fcf9915 Compare February 20, 2024 13:24
@erisu erisu merged commit bd400cf into apache:master Feb 20, 2024
3 checks passed
@erisu erisu deleted the feat/bump-electron-related-dependencies branch February 20, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants