Update run to work with Cordova CLI prior version 9.x #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change static path in run.js to dynamic - Update unit tests - Update DOCUMENTATION.md
GedasGa
changed the title
GedasGa
changed the title
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 441 442 +1
=====================================
+ Hits 441 442 +1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 441 442 +1
=====================================
+ Hits 441 442 +1
Continue to review full report at Codecov.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
electron
Motivation and Context
Running electron platform with cordova-lib prior 9.x.x breaks. This is because prior to Cordova 9, the electron platform is added to
cordova-electronfolder, but in therun.jswe have a static path pointing to./platforms/electron/www/main.js. Therefore it's unable to locate themain.jsand results in an error.Description
Changed static string in the
run.jsto more "dynamic" approach usingpath.resolvewith__dirname. Also, updated tests to test this functionality.Testing
Added and ran electron platform with both
cordova (8.1.2)andcordova-nighly (9.0.0)versions. Also, executed automated tests using:Checklist
(platform)if this change only applies to one platform (e.g.(android))