fix: do not pack rejections from resolve in array #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We use the package
resolve
to find out if a requested dependency is already installed. That package exports a callback based async API that we promisify usingpify
. Since the callback ofresolve
is called with multiple result arguments, we need to use themultiArgs
option ofpify
here. Unfortunately that also wraps the errors ofresolve
into an array.Description
This PR unwraps the errors returned by our promisified
resolve
.Testing
Manual