(iOS) add undeclared dependency underscore

[merceyz]

Platforms affected

iOS

Motivation and Context

cordova-ios depends on underscore but doesn't declare it as a dependency

cordova-ios/bin/templates/scripts/cordova/lib/projectFile.js

Line 22 in 048c1ca

const _ = require('underscore');

Description

Added underscore as a dependency

Testing

Ran cordova prepare ios under a strict dependency environment

Checklist

• I've run the tests to see all new and existing tests pass
• I added automated test coverage as appropriate for this change
• Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
• I've updated the documentation if necessary

[plchampigny]

@NiklasMerz can this be fixed? This is annoying to add underscore dependency manually when using cordova-ios

[NiklasMerz]

LGTM 👍

[breautek]

I'm genuinely surprised how long this went unnoticed. Underscore usage have been in the framework for years, and as far as I can tell it was never added as a dependency.

Thanks for your contribution @merceyz

[merceyz]

Hoisting does wonders in hiding these sorts of problems, Yarn PnP is strict on these and threw an error immediately when running yarn cordova prepare ios