chore: remove long-unused codeSignResourceRules option #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xcode hasn't supported specifying codesigning resource rules since pre-Mavericks, so this serves no purpose anymore. Closes apache#563.
Codecov Report
@@ Coverage Diff @@
## master #1308 +/- ##
==========================================
+ Coverage 78.48% 78.51% +0.03%
==========================================
Files 15 15
Lines 1780 1778 -2
==========================================
- Hits 1397 1396 -1
+ Misses 383 382 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
timbru31
approved these changes
Apr 15, 2023
erisu
changed the title
erisu
approved these changes
Apr 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
Xcode hasn't supported specifying codesigning resource rules since pre-Mavericks, so this serves no purpose anymore.
Closes #563.
Description
Remove support for the
--codeSignResourceRulesoption.Testing
All unit tests pass.
Checklist