-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Use single 1024x1024 icon #1309
Conversation
We should make sure this works properly if someone just puts There's a part of me that thinks it would be good to have some support for customizing the notification and watch icons, but that would involve dynamically adding them to the .xcassets Contents.json only if they were specified, which feels like it would be error-prone if people are mixing manual changes and automatic ones 😞 |
Codecov Report
@@ Coverage Diff @@
## master #1309 +/- ##
=======================================
Coverage 78.48% 78.48%
=======================================
Files 15 15
Lines 1780 1780
=======================================
Hits 1397 1397
Misses 383 383
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
If using single icon, Xcode only allows a single icon, doesn’t allow to add a different icon notifications. |
Ahh okay |
FWIW, we've gone back in our apps and just supplied the icons that were missing (so that we aren't relying on a feature that may not even make it into release). This appears to cover all current icons, at least for the iPhone models. |
I believe it was decided to staying on iOS 11, so I think this PR can be closed. |
Xcode 14 allows to use a single 1024x1024 icon instead of having all the icon sizes.
It's breaking because it requires Xcode 14, but since Xcode 14.1 is going to be required for app store submissions starting the 25 of April, I think we are good.
Removed the icon sizes link because it was broken
Closes #1019
closes #1233