CB-11475 Ignore unsupported 60x60 icon #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shazron, could you please take a look? |
Current coverage is 51.81%@@ master #230 diff @@
==========================================
Files 11 11
Lines 882 882
Methods 132 132
Messages 0 0
Branches 143 143
==========================================
Hits 457 457
Misses 425 425
Partials 0 0
|
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 60x60 icon is not used in
AppIconcatalog and has been removed in 68af7ea. However if you have<icon width="60" height="60" ...>inconfig.xmlit'll be added to catalog asicon-60.png. This will result in Xcode warningThe app icon set "AppIcon" has an unassigned childSee also CB-11475