Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-11712 - <name> changes in config.xml does a 'search and replace all' for occurrences of the old name with the new name in the pbxproj #246

Closed
wants to merge 1 commit into from

Conversation

shazron
Copy link
Member

@shazron shazron commented Aug 31, 2016

The error message looks like this:

Error: The product name change (<name> tag) in config.xml is not supported dynamically.
To change your product name, you have to remove, then add your ios platform again.
Make sure you save your plugins beforehand using `cordova plugin save`.
        cordova plugin save
        cordova platform rm ios
        cordova platform add ios

Not sure if I'm supposed to be hardcoding cordova for downstream distributions.

@shazron
Copy link
Member Author

shazron commented Aug 31, 2016

I am fixing the tests.

@codecov-io
Copy link

codecov-io commented Aug 31, 2016

Current coverage is 55.63% (diff: 100%)

Merging #246 into master will decrease coverage by 0.76%

@@             master       #246   diff @@
==========================================
  Files            11         11          
  Lines          1023       1003    -20   
  Methods         144        144          
  Messages          0          0          
  Branches        168        168          
==========================================
- Hits            577        558    -19   
+ Misses          446        445     -1   
  Partials          0          0          

Powered by Codecov. Last update 2085ab9...ba2a77d

@shazron
Copy link
Member Author

shazron commented Aug 31, 2016

Tests pass, squashing the commits.

…l' for occurrences of the old name with the new name in the pbxproj
@asfgit asfgit closed this in eb5eb99 Aug 31, 2016
@shazron shazron deleted the CB-11712 branch August 31, 2016 22:29
kerrishotts pushed a commit to kerrishotts/cordova-ios that referenced this pull request Sep 1, 2016
…l' for occurrences of the old name with the new name in the pbxproj

 This closes apache#246
@bromeostasis
Copy link

@shazron just updated cordova and started running into this error. We use cordova to apply one codebase to several different white labeled apps with different data and styles.

Until now we've been dynamically changing the name by removing/re-adding the platform we're working on and then using different sets of config.xml/stylesheet/js config. Is there any way to continue this type of behavior, or will we have to create separate cordova projects for each of our White Labels? This would be a serious pain considering we have over 20!!

Thanks!

@jcesarmobile
Copy link
Member

What is your error exactly?

@bromeostasis
Copy link

@jcesarmobile well I'm running into the expected error:

Error: The product name change (<name> tag) in config.xml is not supported dynamically.
To change your product name, you have to remove, then add your ios platform again.
Make sure you save your plugins beforehand using `cordova plugin save`.
        cordova plugin save
        cordova platform rm ios
        cordova platform add ios

which I understand the purpose of. We definitely were switching out the <name> tag to change the name of the project. I'm just wondering if there's any way to switch the name of the project dynamically with the latest version of cordova, since that's one of our main reasons for using it.

@jcesarmobile
Copy link
Member

But you said that you were removing and re adding the platforms, so it shouldn't complain in that case.
This might be related to Cordova CLI 7 also using the package.json for storing the platforms. Can you create a new issue on http://issues.cordova.io/?

@bromeostasis
Copy link

@jcesarmobile sure, I'll confirm the specific steps and then post a new issue. Any thoughts on a workaround if this a problem?

@jcesarmobile
Copy link
Member

only downgrade to previous CLI

@bromeostasis
Copy link

@jcesarmobile I found a few bugs on our end that prevented things from working right; looks like the upgrade just exposed those, so no problems here!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants