-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-11712 - <name> changes in config.xml does a 'search and replace all' for occurrences of the old name with the new name in the pbxproj #246
Conversation
I am fixing the tests. |
Current coverage is 55.63% (diff: 100%)@@ master #246 diff @@
==========================================
Files 11 11
Lines 1023 1003 -20
Methods 144 144
Messages 0 0
Branches 168 168
==========================================
- Hits 577 558 -19
+ Misses 446 445 -1
Partials 0 0
|
Tests pass, squashing the commits. |
…l' for occurrences of the old name with the new name in the pbxproj
…l' for occurrences of the old name with the new name in the pbxproj This closes apache#246
@shazron just updated cordova and started running into this error. We use cordova to apply one codebase to several different white labeled apps with different data and styles. Until now we've been dynamically changing the name by removing/re-adding the platform we're working on and then using different sets of config.xml/stylesheet/js config. Is there any way to continue this type of behavior, or will we have to create separate cordova projects for each of our White Labels? This would be a serious pain considering we have over 20!! Thanks! |
What is your error exactly? |
@jcesarmobile well I'm running into the expected error:
which I understand the purpose of. We definitely were switching out the <name> tag to change the name of the project. I'm just wondering if there's any way to switch the name of the project dynamically with the latest version of cordova, since that's one of our main reasons for using it. |
But you said that you were removing and re adding the platforms, so it shouldn't complain in that case. |
@jcesarmobile sure, I'll confirm the specific steps and then post a new issue. Any thoughts on a workaround if this a problem? |
only downgrade to previous CLI |
@jcesarmobile I found a few bugs on our end that prevented things from working right; looks like the upgrade just exposed those, so no problems here! Thanks! |
The error message looks like this:
Not sure if I'm supposed to be hardcoding
cordova
for downstream distributions.