Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-12050 ios: Create shared scheme for framework target, for Carthage support #297

Closed
wants to merge 1 commit into from

Conversation

khawkins
Copy link
Contributor

Platforms affected

iOS

What does this PR do?

Adds a shared build scheme for the Cordova framework target of the iOS project, which is a prerequisite for Carthage support.

What testing has been done on this change?

  1. Manually ran Carthage against this change, to ensure that it was able to download and build the framework target.
  2. Imported the resultant framework into a test iOS app (Objective-C), instantiated a CDVViewController instance, added the default configuration to the app (config.xml, www/index.xml), and verified that the expected view would load at app startup.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

NB: There are possibly scenarios where automated testing of Carthage support could be considered, but I'm not sure what that looks like at this point.

@shazron
Copy link
Member

shazron commented Mar 16, 2017

Good stuff, tested it, it works as you described.
Two issues related to using module import using @import Cordova; which I will address in a separate PR though:
screen shot 2017-03-16 at 3 53 02 pm

@asfgit asfgit closed this in 3a8e994 Mar 16, 2017
@shazron
Copy link
Member

shazron commented Mar 16, 2017

Posted #298

@khawkins khawkins deleted the CB-12050 branch March 29, 2017 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants