Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-13093: (iOS) Infinite looping when stressing navigation #328

Merged
merged 2 commits into from
Aug 8, 2017

Conversation

luissilvaos
Copy link
Contributor

@luissilvaos luissilvaos commented Jul 24, 2017

Platforms affected

iOS

What does this PR do?

Fix the navigations that starts with the STATE_WAITING_FOR_LOAD_START by calling the self webview:didFailLoadWithError method instead of delegating it.

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@codecov-io
Copy link

codecov-io commented Jul 24, 2017

Codecov Report

Merging #328 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   63.97%   63.97%           
=======================================
  Files          14       14           
  Lines        1674     1674           
  Branches      277      277           
=======================================
  Hits         1071     1071           
  Misses        603      603

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8edd13a...0d00b20. Read the comment docs.

@shazron
Copy link
Member

shazron commented Jul 27, 2017

Thanks for the PR. Is this issue reproducible by a unit test? See https://github.com/apache/cordova-ios/blob/master/tests/CordovaLibTests/CDVWebViewDelegateTests.m

@luissilvaos
Copy link
Contributor Author

Yes, it is. Please check my last commit.

@shazron shazron self-assigned this Aug 8, 2017
@shazron shazron merged commit d44cec6 into apache:master Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants